Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 161343002: Add back DocumentType error so that Dartium can build. (Closed)

Created:
6 years, 10 months ago by Emily Fortuna
Modified:
6 years, 10 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add back DocumentType error so that Dartium can build. BUG= Committed: https://code.google.com/p/dart/source/detail?r=32625

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/analyze_api_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/scripts/generator.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
TBR I'll be adding a different fix in to actually fix this warning, but in ...
6 years, 10 months ago (2014-02-12 21:32:06 UTC) #1
Emily Fortuna
Committed patchset #1 manually as r32625 (presubmit successful).
6 years, 10 months ago (2014-02-12 21:32:24 UTC) #2
blois
6 years, 10 months ago (2014-02-12 21:37:32 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698