Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 16123036: Clean up dart:io exceptions. (Closed)

Created:
7 years, 6 months ago by Anders Johnsen
Modified:
7 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Clean up dart:io exceptions. - Introduce IOException. - Remove HttpParserException. - Merge RedirectLimitExceededException and RedirectLoopException into RedirectException. - Remove 'IO' from FileIOException, DirectoryIOException, LinkIOException and SocketIOException. BUG=https://code.google.com/p/dart/issues/detail?id=9955 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=23848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -300 lines) Patch
M pkg/http/test/client_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/test/safe_http_server.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/http/test/utils.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M pkg/scheduled_test/lib/src/scheduled_server/safe_http_server.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_server_test.dart View 6 chunks +18 lines, -18 lines 0 comments Download
M runtime/bin/dartutils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/bin/directory.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/secure_socket.h View 2 chunks +6 lines, -6 lines 0 comments Download
M runtime/bin/socket_patch.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/stdio_patch.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/source_file_provider.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/samples/leap/leap_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/dartdoc/lib/dartdoc.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/dartdoc/lib/src/export_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/command.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/hosted_source.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/http.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/io.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/safe_http_server.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/utils.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M sdk/lib/io/common.dart View 1 chunk +10 lines, -3 lines 0 comments Download
M sdk/lib/io/directory.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/io/directory_impl.dart View 9 chunks +10 lines, -10 lines 0 comments Download
M sdk/lib/io/file.dart View 24 chunks +26 lines, -26 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 24 chunks +28 lines, -28 lines 0 comments Download
M sdk/lib/io/file_system_entity.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/http.dart View 1 chunk +9 lines, -15 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 4 chunks +5 lines, -6 lines 0 comments Download
M sdk/lib/io/http_parser.dart View 19 chunks +22 lines, -30 lines 0 comments Download
M sdk/lib/io/link.dart View 7 chunks +9 lines, -9 lines 0 comments Download
M sdk/lib/io/mime_multipart_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/process.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/secure_socket.dart View 5 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/io/socket.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/io/websocket.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/directory_error_test.dart View 9 chunks +12 lines, -12 lines 0 comments Download
M tests/standalone/io/directory_list_nonexistent_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/io/directory_test.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M tests/standalone/io/file_error_test.dart View 9 chunks +9 lines, -9 lines 0 comments Download
M tests/standalone/io/file_invalid_arguments_test.dart View 9 chunks +10 lines, -10 lines 0 comments Download
M tests/standalone/io/file_test.dart View 10 chunks +12 lines, -12 lines 0 comments Download
M tests/standalone/io/http_client_connect_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_date_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/http_headers_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/http_parser_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/http_redirect_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_server_response_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_shutdown_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/standalone/io/raw_socket_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/secure_no_builtin_roots_database_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_no_builtin_roots_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_server_socket_test.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/standalone/io/socket_exception_test.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M tests/standalone/io/socket_invalid_arguments_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/socket_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/url_encoding_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/web_socket_protocol_processor_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 6 months ago (2013-06-11 11:27:12 UTC) #1
Søren Gjesse
lgtm
7 years, 6 months ago (2013-06-11 13:09:10 UTC) #2
Søren Gjesse
On 2013/06/11 13:09:10, Søren Gjesse wrote: > lgtm And remember to send out a breaking ...
7 years, 6 months ago (2013-06-11 13:09:34 UTC) #3
Anders Johnsen
7 years, 6 months ago (2013-06-11 13:16:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r23848 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698