Issue 161213002: Tolerate a comment with no end paragraph tag when generating preview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 161213002: Tolerate a comment with no end paragraph tag when generating preview (Closed)

Created:
6 years, 10 months ago by Alan Knight

Modified:
6 years, 10 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Tolerate a comment with no end paragraph tag when generating preview BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=32662

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	pkg/docgen/lib/docgen.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Alan Knight

See https://code.google.com/p/dart/issues/detail?id=10874 The example doesn't crash as described in the original bug, but it did ...

6 years, 10 months ago (2014-02-12 21:06:46 UTC) #1

Emily Fortuna

this doesn't cause any weird display issues? lgtm...

6 years, 10 months ago (2014-02-12 22:25:37 UTC) #2

Alan Knight

You're right, it doesn't work. Switched it to use a hard-coded message instead.

6 years, 10 months ago (2014-02-13 01:21:24 UTC) #3

Alan Knight

6 years, 10 months ago (2014-02-13 17:47:41 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r32662 (presubmit successful).