Add browser-compatible version.

Add browser-compatible version.

Still need to find a way to test it.

R=floitsch@google.com

Committed: d73108e8ccc28e2704e05b8e4bc07e1da23c68b3

[Lasse Reichstein Nielsen, 2016-01-21 12:00:39]

lrn@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2016-01-21 12:53:57]

LGTM, although I would find it cleaner, if io and web would both be in their
subdirectories.

https://codereview.chromium.org/1612003002/diff/1/lib/resource.dart
File lib/resource.dart (right):

https://codereview.chromium.org/1612003002/diff/1/lib/resource.dart#newcode25
lib/resource.dart:25: /// so it doesn't work in the browser.
Mention browser_resource here.

https://codereview.chromium.org/1612003002/diff/1/lib/src/browser/html_io.dart
File lib/src/browser/html_io.dart (right):

https://codereview.chromium.org/1612003002/diff/1/lib/src/browser/html_io.dar...
lib/src/browser/html_io.dart:10: /// Read the bytes of a URI as a stream of
bytes.
Reads.
Same for the others.

https://codereview.chromium.org/1612003002/diff/1/lib/src/browser/resource.dart
File lib/src/browser/resource.dart (right):

https://codereview.chromium.org/1612003002/diff/1/lib/src/browser/resource.da...
lib/src/browser/resource.dart:7: /// A resource is identified by a URI. It can
be loaded as bytes or data.
"or string"?

https://codereview.chromium.org/1612003002/diff/1/lib/src/browser/resource.da...
lib/src/browser/resource.dart:42: /// Creates a resource object with the given
[uri] as location.
I would inherit these comments for both Resource-classes (web and io) from
impl.Resource.

https://codereview.chromium.org/1612003002/diff/1/lib/src/resource.dart
File lib/src/resource.dart (right):

https://codereview.chromium.org/1612003002/diff/1/lib/src/resource.dart#newco...
lib/src/resource.dart:25: /// so it doesn't work in the browser.
Mention the browser version.

https://codereview.chromium.org/1612003002/diff/1/lib/src/resource_impl.dart
File lib/src/resource_impl.dart (right):

https://codereview.chromium.org/1612003002/diff/1/lib/src/resource_impl.dart#...
lib/src/resource_impl.dart:16: /// When configuarble imports make it possible,
drop the intermediate classes
This shouldn't be a dartdoc.

[Lasse Reichstein Nielsen, 2016-01-25 10:48:37]

https://codereview.chromium.org/1612003002/diff/1/lib/resource.dart
File lib/resource.dart (right):

https://codereview.chromium.org/1612003002/diff/1/lib/resource.dart#newcode25
lib/resource.dart:25: /// so it doesn't work in the browser.
On 2016/01/21 12:53:57, floitsch wrote:
> Mention browser_resource here.

Done.

https://codereview.chromium.org/1612003002/diff/1/lib/src/browser/html_io.dart
File lib/src/browser/html_io.dart (right):

https://codereview.chromium.org/1612003002/diff/1/lib/src/browser/html_io.dar...
lib/src/browser/html_io.dart:10: /// Read the bytes of a URI as a stream of
bytes.
On 2016/01/21 12:53:57, floitsch wrote:
> Reads.
> Same for the others.

Done.

https://codereview.chromium.org/1612003002/diff/1/lib/src/browser/resource.dart
File lib/src/browser/resource.dart (right):

https://codereview.chromium.org/1612003002/diff/1/lib/src/browser/resource.da...
lib/src/browser/resource.dart:7: /// A resource is identified by a URI. It can
be loaded as bytes or data.
On 2016/01/21 12:53:57, floitsch wrote:
> "or string"?

Done.

https://codereview.chromium.org/1612003002/diff/1/lib/src/browser/resource.da...
lib/src/browser/resource.dart:42: /// Creates a resource object with the given
[uri] as location.
The constructor comment can't be inherited, but I'll move the other ones.

https://codereview.chromium.org/1612003002/diff/1/lib/src/resource.dart
File lib/src/resource.dart (right):

https://codereview.chromium.org/1612003002/diff/1/lib/src/resource.dart#newco...
lib/src/resource.dart:25: /// so it doesn't work in the browser.
On 2016/01/21 12:53:57, floitsch wrote:
> Mention the browser version.

Done.

https://codereview.chromium.org/1612003002/diff/1/lib/src/resource_impl.dart
File lib/src/resource_impl.dart (right):

https://codereview.chromium.org/1612003002/diff/1/lib/src/resource_impl.dart#...
lib/src/resource_impl.dart:16: /// When configuarble imports make it possible,
drop the intermediate classes
On 2016/01/21 12:53:57, floitsch wrote:
> This shouldn't be a dartdoc.

Done.

[Lasse Reichstein Nielsen, 2016-01-26 09:19:31]

Description was changed from

==========
Add browser-compatible version.

Still need to find a way to test it.
==========

to

==========
Add browser-compatible version.

Still need to find a way to test it.

R=floitsch@google.com

Committed: d73108e8ccc28e2704e05b8e4bc07e1da23c68b3
==========

[Lasse Reichstein Nielsen, 2016-01-26 09:19:32]

Committed patchset #3 (id:40001) manually as
d73108e8ccc28e2704e05b8e4bc07e1da23c68b3 (presubmit successful).