Issue 16114013: Reland "Add --version option to dart2js and add version information (if available) to generated cod…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16114013: Reland "Add --version option to dart2js and add version information (if available) to generated cod… (Closed)

Created:
7 years, 6 months ago by kasperl

Modified:
7 years, 6 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reland "Add --version option to dart2js and add version information (if available) to generated code." R=ahe@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23378

Patch Set 1 #

Patch Set 2 : Use compiler.buildId from emitter. #

Patch Set 3 : Fix formatting. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -21 lines)			Patch
M	sdk/bin/dart2js	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	sdk/bin/dart2js.bat	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1 2	3 chunks	+9 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart2js.dart	View		5 chunks	+21 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1	4 chunks	+8 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

Committed patchset #3 manually as r23378 (presubmit successful).

7 years, 6 months ago (2013-05-30 05:49:36 UTC) #1

kasperl

TBR'ed. Still not quite sure why this broke on the build bots when I tried ...

7 years, 6 months ago (2013-05-30 05:50:53 UTC) #2

ahe

I thought it was pretty obvious: you imported dart:io into the compiler. You're not doing ...

7 years, 6 months ago (2013-05-30 06:04:48 UTC) #3

kasperl

7 years, 6 months ago (2013-05-30 06:22:10 UTC) #4

Message was sent while issue was closed.

On 2013/05/30 06:04:48, ahe wrote:
> I thought it was pretty obvious: you imported dart:io into the compiler.
You're
> not doing that anymore, so LGTM!

Yeah, I just figured that out too :-) As you say it is pretty obvious.

Expand Messages | Collapse Messages