Issue 16113003: Report SWC. and CTEC.CONST_FIELD_INITIALIZER_NOT_ASSIGNABLE

Issue 16113003: Report SWC. and CTEC.CONST_FIELD_INITIALIZER_NOT_ASSIGNABLE (Closed)

Created:
7 years, 7 months ago by scheglov

Modified:
7 years, 6 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report SWC. and CTEC.CONST_FIELD_INITIALIZER_NOT_ASSIGNABLE R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23285

Patch Set 2 : Add comment #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -10 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java	View		1 chunk	+19 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1	2 chunks	+54 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/CompileTimeErrorCodeTest.java	View		3 chunks	+13 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticWarningCodeTest.java	View	1	1 chunk	+13 lines, -2 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/16113003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/16113003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode1946 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:1946: * TODO(scheglov) nit: missing comment

7 years, 6 months ago (2013-05-28 13:48:12 UTC) #2

scheglov

https://codereview.chromium.org/16113003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/16113003/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode1946 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:1946: * TODO(scheglov) On 2013/05/28 13:48:13, Brian Wilkerson wrote: > ...

7 years, 6 months ago (2013-05-28 15:33:31 UTC) #3

scheglov

7 years, 6 months ago (2013-05-28 15:33:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r23285 (presubmit successful).

Expand Messages | Collapse Messages