Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 16109009: Add a JS AST null value to the generated field metadata instead of null when a field does not have … (Closed)

Created:
7 years, 6 months ago by ngeoffray
Modified:
7 years, 6 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a JS AST null value to the generated field metadata instead of null when a field does not have metadata. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=23669

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/lib/mirrors/metadata_test.dart View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 6 months ago (2013-06-06 09:40:23 UTC) #1
ahe
LGTM, thank you!
7 years, 6 months ago (2013-06-06 09:43:08 UTC) #2
ngeoffray
7 years, 6 months ago (2013-06-06 09:43:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23669 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698