Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 16103010: Fixes for translator and DDA status files. (Closed)

Created:
7 years, 6 months ago by scheglov
Modified:
7 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixes for translator and DDA status files. Almost everything is again translated automatically. There are three fragments which we have to replace to source level. One for performance reasons; two others - to avoid using IO. Now we are green for co19 tests, execute 4034 of them in 2:07, 132 failures. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+641 lines, -201 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 2 chunks +13 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 4 chunks +14 lines, -2 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 6 chunks +69 lines, -8 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/CollectionSemanticProcessor.java View 1 chunk +5 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/ObjectSemanticProcessor.java View 5 chunks +30 lines, -7 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java View 1 chunk +2 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/CollectionSemanticProcessorTest.java View 1 chunk +9 lines, -2 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java View 5 chunks +36 lines, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/ast.dart View 13 chunks +232 lines, -29 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/constant.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/element.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/engine.dart View 4 chunks +18 lines, -18 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/error.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_core.dart View 2 chunks +13 lines, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/parser.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/resolver.dart View 17 chunks +149 lines, -107 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/sdk.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer_experimental/test/generated/resolver_test.dart View 5 chunks +36 lines, -4 lines 0 comments Download
M tests/co19/co19-analyzer2.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 6 months ago (2013-06-05 00:49:55 UTC) #1
Brian Wilkerson
LGTM. I didn't look at all of the generated code, but did look at some.
7 years, 6 months ago (2013-06-05 00:56:36 UTC) #2
scheglov
7 years, 6 months ago (2013-06-05 00:59:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23624 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698