Make the StackTrace library better handle core library frames.

Make the StackTrace library better handle core library frames.

Core library stack frames now have libraries and meaningful line numbers, so in
general we should preserve those. However, terse stack traces don't care about
the internal workings of the core libraries, so they now explicitly remove the
library and line number information.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23621

[Bob Nystrom, 2013-06-04 23:21:05]

I wonder if this should still just strip out the corelib file names and line
numbers. They aren't going to be meaningful since, I think, the actual files are
jammed inside the dart executable.

Either way, one suggestion then LGTM.

https://codereview.chromium.org/16097012/diff/1/pkg/stack_trace/test/frame_te...
File pkg/stack_trace/test/frame_test.dart (right):

https://codereview.chromium.org/16097012/diff/1/pkg/stack_trace/test/frame_te...
pkg/stack_trace/test/frame_test.dart:164: equals('dart:core/uri.dart 5:10 in
Foo.<fn>'));
These line numbers are going to be brittle. Maybe use \d+?

[nweiz, 2013-06-04 23:35:58]

The core library sources are actually in the SDK, presumably to aid with
debugging, so keeping the listings around makes some sense.

https://codereview.chromium.org/16097012/diff/1/pkg/stack_trace/test/frame_te...
File pkg/stack_trace/test/frame_test.dart (right):

https://codereview.chromium.org/16097012/diff/1/pkg/stack_trace/test/frame_te...
pkg/stack_trace/test/frame_test.dart:164: equals('dart:core/uri.dart 5:10 in
Foo.<fn>'));
On 2013/06/04 23:21:05, Bob Nystrom wrote:
> These line numbers are going to be brittle. Maybe use \d+?

Everything is parsed from manually-entered strings to avoid any coupling with
the structure of the core libraries.

[nweiz, 2013-06-04 23:36:36]

Committed patchset #1 manually as r23621 (presubmit successful).