Add safari browser controller.

Add safari browser controller.

Additionally, fix some bugs in the browser controller discovered while enabling safari.

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23240

[kustermann, 2013-05-28 07:42:39]

lgtm

https://codereview.chromium.org/16094004/diff/5001/tools/testing/dart/browser...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/16094004/diff/5001/tools/testing/dart/browser...
tools/testing/dart/browser_controller.dart:204: bool versionOnNextLine = false;
Small comment about how the file looks like would be nice.

https://codereview.chromium.org/16094004/diff/5001/tools/testing/dart/browser...
tools/testing/dart/browser_controller.dart:216: var file = new
File("${path.toString()}/launch.html");
No reason to call 'toString()' explicitly (otherwise use 'toNativePath()' if
it's a Path).

https://codereview.chromium.org/16094004/diff/5001/tools/testing/dart/browser...
tools/testing/dart/browser_controller.dart:586: if (underTermination) return;
We could also assert/throw here, since we never reuse Browser objects (i.e. if
we want to call 'start(url)' we first call 'getInstance()', right?

https://codereview.chromium.org/16094004/diff/5001/tools/testing/dart/browser...
tools/testing/dart/browser_controller.dart:748: throw("Error returning content
to browser: $error");
don't use 'throw()' but rather 'throw ""'

https://codereview.chromium.org/16094004/diff/5001/tools/testing/dart/test_ru...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/16094004/diff/5001/tools/testing/dart/test_ru...
tools/testing/dart/test_runner.dart:1659: && !_isSeleniumAvailable ||
Tab character?

[ricow1, 2013-05-28 08:07:30]

thx

https://codereview.chromium.org/16094004/diff/5001/tools/testing/dart/browser...
File tools/testing/dart/browser_controller.dart (right):

https://codereview.chromium.org/16094004/diff/5001/tools/testing/dart/browser...
tools/testing/dart/browser_controller.dart:204: bool versionOnNextLine = false;
On 2013/05/28 07:42:39, kustermann wrote:
> Small comment about how the file looks like would be nice.

Done.

https://codereview.chromium.org/16094004/diff/5001/tools/testing/dart/browser...
tools/testing/dart/browser_controller.dart:216: var file = new
File("${path.toString()}/launch.html");
On 2013/05/28 07:42:39, kustermann wrote:
> No reason to call 'toString()' explicitly (otherwise use 'toNativePath()' if
> it's a Path).

Done.

https://codereview.chromium.org/16094004/diff/5001/tools/testing/dart/browser...
tools/testing/dart/browser_controller.dart:586: if (underTermination) return;
On 2013/05/28 07:42:39, kustermann wrote:
> We could also assert/throw here, since we never reuse Browser objects (i.e. if
> we want to call 'start(url)' we first call 'getInstance()', right?
Here is what can happen:
All tests but one are done, the test times out and we get in here. Now since
everything is done we will shutdown all the other browsers and close the http
server. Right below we start a new browser and points it to the driver page,
while sending back response to that we may close the http server in the
termination step (because this is async)

https://codereview.chromium.org/16094004/diff/5001/tools/testing/dart/browser...
tools/testing/dart/browser_controller.dart:748: throw("Error returning content
to browser: $error");
On 2013/05/28 07:42:39, kustermann wrote:
> don't use 'throw()' but rather 'throw ""'

Done.

https://codereview.chromium.org/16094004/diff/5001/tools/testing/dart/test_ru...
File tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/16094004/diff/5001/tools/testing/dart/test_ru...
tools/testing/dart/test_runner.dart:1659: && !_isSeleniumAvailable ||
On 2013/05/28 07:42:39, kustermann wrote:
> Tab character?
Stupid mac :-)

[ricow1, 2013-05-28 08:41:14]

Committed patchset #5 manually as r23240 (presubmit successful).