Issue 16093021: Fix hash code tests to be non-flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16093021: Fix hash code tests to be non-flaky. (Closed)

Created:
7 years, 6 months ago by kasperl

Modified:
7 years, 6 months ago

Reviewers:
ahe, kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix hash code tests to be non-flaky. R=ahe@google.com, kustermann@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23590

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -13 lines)			Patch
	M	tests/compiler/dart2js_extra/hash_code_test.dart	View		4 chunks	+16 lines, -13 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/16093021/diff/1/tests/compiler/dart2js_extra/hash_code_test.dart File tests/compiler/dart2js_extra/hash_code_test.dart (right): https://codereview.chromium.org/16093021/diff/1/tests/compiler/dart2js_extra/hash_code_test.dart#newcode20 tests/compiler/dart2js_extra/hash_code_test.dart:20: check(value1, value2, {identityHashCode}) { bool identityHashCode: false https://codereview.chromium.org/16093021/diff/1/tests/compiler/dart2js_extra/hash_code_test.dart#newcode32 ...

7 years, 6 months ago (2013-06-04 13:19:48 UTC) #2

kasperl

7 years, 6 months ago (2013-06-04 13:23:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r23590 (presubmit successful).

Expand Messages | Collapse Messages