dart:io | Add documentation for the default root certificate database for secure networking.

dart:io | Add documentation for the default root certificate database for secure networking.

BUG=dartbug.com/8229, dartbug.com/8250
R=lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23460

[Lasse Reichstein Nielsen, 2013-05-31 08:49:06]

lgtm

https://codereview.chromium.org/16081005/diff/1/sdk/lib/io/secure_socket.dart
File sdk/lib/io/secure_socket.dart (right):

https://codereview.chromium.org/16081005/diff/1/sdk/lib/io/secure_socket.dart...
sdk/lib/io/secure_socket.dart:162: * If no value is provided for the [database]
argument, then only the
We'd usually write "If the [database] argument is omitted, then ...".

https://codereview.chromium.org/16081005/diff/1/sdk/lib/io/secure_socket.dart...
sdk/lib/io/secure_socket.dart:163: * builtin root certificates are used, unless
they are disabled.
"unless they are disabled"?
How can they be disabled? What happens if they are?
The "unless" could be seen as being relative to the "only", so if the root
certificates are disabled, more than just the root certificates are used.

How about.
"... onlt the builtin root certificates are used. If they are also disabled,
...<something happens - no certificates are used?>"

https://codereview.chromium.org/16081005/diff/1/sdk/lib/io/secure_socket.dart...
sdk/lib/io/secure_socket.dart:176: *                            
useBuiltinRoots: false);
So what happens if you do:
  initialize(password: "my_password", useBuiltinRoots: false)
?

[Bill Hesse, 2013-05-31 09:08:37]

https://codereview.chromium.org/16081005/diff/1/sdk/lib/io/secure_socket.dart
File sdk/lib/io/secure_socket.dart (right):

https://codereview.chromium.org/16081005/diff/1/sdk/lib/io/secure_socket.dart...
sdk/lib/io/secure_socket.dart:162: * If no value is provided for the [database]
argument, then only the
On 2013/05/31 08:49:06, Lasse Reichstein Nielsen wrote:
> We'd usually write "If the [database] argument is omitted, then ...".

Done.

https://codereview.chromium.org/16081005/diff/1/sdk/lib/io/secure_socket.dart...
sdk/lib/io/secure_socket.dart:163: * builtin root certificates are used, unless
they are disabled.
On 2013/05/31 08:49:06, Lasse Reichstein Nielsen wrote:
> "unless they are disabled"?
> How can they be disabled? What happens if they are?
> The "unless" could be seen as being relative to the "only", so if the root
> certificates are disabled, more than just the root certificates are used.
> 
> How about.
> "... onlt the builtin root certificates are used. If they are also disabled,
> ...<something happens - no certificates are used?>"

Done.

https://codereview.chromium.org/16081005/diff/1/sdk/lib/io/secure_socket.dart...
sdk/lib/io/secure_socket.dart:176: *                            
useBuiltinRoots: false);
On 2013/05/31 08:49:06, Lasse Reichstein Nielsen wrote:
> So what happens if you do:
>   initialize(password: "my_password", useBuiltinRoots: false)
> ?

Nothing useful.  No certificates are available.  you can't do much.

[Bill Hesse, 2013-05-31 09:08:59]

Committed patchset #3 manually as r23460 (presubmit successful).

[monikag, 2013-05-31 09:09:20]

On 2013/05/31 09:08:59, Bill Hesse wrote:
> Committed patchset #3 manually as r23460 (presubmit successful).