Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 160753004: Do not resolve type arguments when only a resolved type class is needed to (Closed)

Created:
6 years, 10 months ago by regis
Modified:
6 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Do not resolve type arguments when only a resolved type class is needed to calculate number of type arguments during type finalization (issue 16640). Add regression test. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=32624

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -30 lines) Patch
M runtime/vm/class_finalizer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/class_finalizer.cc View 1 chunk +41 lines, -29 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -1 line 0 comments Download
A tests/language/regress_16640_test.dart View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
6 years, 10 months ago (2014-02-12 19:47:40 UTC) #1
siva
lgtm
6 years, 10 months ago (2014-02-12 21:17:13 UTC) #2
regis
6 years, 10 months ago (2014-02-12 21:19:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r32624 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698