Issue 160613002: Inline polymorphic typed array view stores

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160613002: Inline polymorphic typed array view stores (Closed)

Created:
6 years, 10 months ago by Cutch

Modified:
6 years, 10 months ago

Reviewers:
Florian Schneider, Anders Johnsen, fschneider, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+250 lines, -82 lines)			Patch
M	runtime/vm/flow_graph_optimizer.h	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	3 chunks	+196 lines, -82 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	tests/language/vm/typed_data_polymorphic_view_test.dart	View	1 2	1 chunk	+35 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Anders Johnsen

This appears to be working, but the speedup is not as much as I had ...

6 years, 10 months ago (2014-02-13 09:32:19 UTC) #2

Florian Schneider

LGTM. Please check that our tests cover the polymorphic case.

6 years, 10 months ago (2014-02-13 10:33:36 UTC) #3

Cutch

6 years, 10 months ago (2014-02-13 15:54:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r32656 (presubmit successful).