Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 16059005: Fix a bug where we would emit: (Closed)

Created:
7 years, 7 months ago by ngeoffray
Modified:
7 years, 7 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix a bug where we would emit: for (var t = 42, $.global = 54; ;) which is invalid JavaScript. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=23246

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 1 chunk +7 lines, -3 lines 0 comments Download
A tests/language/for_inlining_test.dart View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ngeoffray
7 years, 7 months ago (2013-05-28 09:41:10 UTC) #1
kasperl
LGTM! https://codereview.chromium.org/16059005/diff/2001/tests/language/for_inlining_test.dart File tests/language/for_inlining_test.dart (right): https://codereview.chromium.org/16059005/diff/2001/tests/language/for_inlining_test.dart#newcode18 tests/language/for_inlining_test.dart:18: for (var t = inlineMe(); t < 42 ...
7 years, 7 months ago (2013-05-28 09:50:19 UTC) #2
ngeoffray
Thanks Kasper. https://codereview.chromium.org/16059005/diff/2001/tests/language/for_inlining_test.dart File tests/language/for_inlining_test.dart (right): https://codereview.chromium.org/16059005/diff/2001/tests/language/for_inlining_test.dart#newcode18 tests/language/for_inlining_test.dart:18: for (var t = inlineMe(); t < ...
7 years, 7 months ago (2013-05-28 10:00:11 UTC) #3
ngeoffray
7 years, 7 months ago (2013-05-28 10:00:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r23246 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698