Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 16058004: Skip language tests which should pass/fail depending on --checked flag (Closed)

Created:
7 years, 7 months ago by scheglov
Modified:
7 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Skip language tests which should pass/fail depending on --checked flag R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23197

Patch Set 1 #

Patch Set 2 : Fail only when --checked #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M tests/language/language.status View 1 1 chunk +25 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
7 years, 7 months ago (2013-05-25 07:05:43 UTC) #1
scheglov
PTAL
7 years, 7 months ago (2013-05-26 04:10:54 UTC) #2
Brian Wilkerson
LGTM
7 years, 7 months ago (2013-05-26 04:50:17 UTC) #3
scheglov
7 years, 7 months ago (2013-05-26 05:49:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r23197 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698