Issue 16054007: Fixes small ARM bugs, and updates status files.

Issue 16054007: Fixes small ARM bugs, and updates status files. (Closed)

Created:
7 years, 6 months ago by zra

Modified:
7 years, 6 months ago

Reviewers:
srdjan, siva, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fixes small ARM bugs, and updates status files. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=23718

Patch Set 3 : #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -14 lines)			Patch
M	runtime/vm/assembler_arm_test.cc	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View		1 chunk	+9 lines, -1 line	1 comment	Download
M	tests/co19/co19-runtime.status	View	1	2 chunks	+8 lines, -6 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+13 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

srdjan

https://codereview.chromium.org/16054007/diff/4001/runtime/vm/assembler_arm_test.cc File runtime/vm/assembler_arm_test.cc (right): https://codereview.chromium.org/16054007/diff/4001/runtime/vm/assembler_arm_test.cc#newcode242 runtime/vm/assembler_arm_test.cc:242: typedef int (*DoubleFPOperations)(); s/DoubleFPOperations/DoubleSqrtNeg/

7 years, 6 months ago (2013-06-06 21:24:42 UTC) #3

zra

7 years, 6 months ago (2013-06-06 21:52:01 UTC) #5

zra

Committed patchset #3 manually as r23718 (presubmit successful).

7 years, 6 months ago (2013-06-06 21:52:30 UTC) #6

Ivan Posva

7 years, 6 months ago (2013-06-06 22:03:55 UTC) #7

Message was sent while issue was closed.

DBC -ip

https://codereview.chromium.org/16054007/diff/8002/runtime/vm/intrinsifier_ar...
File runtime/vm/intrinsifier_arm.cc (right):

https://codereview.chromium.org/16054007/diff/8002/runtime/vm/intrinsifier_ar...
runtime/vm/intrinsifier_arm.cc:1322: __ vcvtid(S0, D0);
Should we update the simulator to throw an exception when converting a NaN to an
int using this instruction?

Expand Messages | Collapse Messages