Issue 16050006: Support for running tests in an iframe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16050006: Support for running tests in an iframe (Closed)

Created:
7 years, 6 months ago by kustermann

Modified:
7 years, 6 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support for running tests in an iframe R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=23400

Patch Set 2 : #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -82 lines)			Patch
	M	pkg/unittest/lib/test_controller.js	View		2 chunks	+18 lines, -4 lines	0 comments	Download
	M	tools/testing/dart/browser_controller.dart	View	1	5 chunks	+97 lines, -78 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

LGTM https://codereview.chromium.org/16050006/diff/1/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/16050006/diff/1/tools/testing/dart/browser_controller.dart#newcode540 tools/testing/dart/browser_controller.dart:540: bool useIframe = !Browser.BROWSERS_WITH_WINDOW_SUPPORT.contains(browserName); long line

7 years, 6 months ago (2013-05-30 11:50:20 UTC) #2

kustermann

https://codereview.chromium.org/16050006/diff/1/tools/testing/dart/browser_controller.dart File tools/testing/dart/browser_controller.dart (right): https://codereview.chromium.org/16050006/diff/1/tools/testing/dart/browser_controller.dart#newcode540 tools/testing/dart/browser_controller.dart:540: bool useIframe = !Browser.BROWSERS_WITH_WINDOW_SUPPORT.contains(browserName); On 2013/05/30 11:50:20, ricow1 wrote: ...

7 years, 6 months ago (2013-05-30 11:53:12 UTC) #3

kustermann

7 years, 6 months ago (2013-05-30 12:16:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r23400 (presubmit successful).

Expand Messages | Collapse Messages

Issue 16050006: Support for running tests in an iframe (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages