Add clearer rules for implementations.

Add clearer rules for implementations.

This helps implementations know how to handle corner cases, and helps
users know what behavior they can rely on.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/stream_channel/commit/c8515f0d6461faeb5c2e8a9cbd58d1924809ae86

[gzoechi, 2016-01-21 12:36:55]

On 2016/01/21 01:08:11, nweiz wrote:

I had to read the sentence containing `[sink]—canceling` a few times and
wondered what this means.
Maybe this some bias of my German native tongue, but I think `-` should be
change dot ` - ` (added spaces) or `, `.

[Bob Nystrom, 2016-01-21 20:38:22]

lgtm

[nweiz, 2016-01-21 23:28:58]

On 2016/01/21 12:36:55, gzoechi wrote:
> On 2016/01/21 01:08:11, nweiz wrote:
> 
> I had to read the sentence containing `[sink]—canceling` a few times and
> wondered what this means.
> Maybe this some bias of my German native tongue, but I think `-` should be
> change dot ` - ` (added spaces) or `, `.

I've considered changing it, but I think I'm going to keep it as-is. This is a
pretty standard use of the em dash (although apparently in the UK it's more
usual to add space around it), and it's the most appropriate punctuation to
indicate that the two sentences are separate but closely related.

[nweiz, 2016-01-21 23:29:18]

Description was changed from

==========
Add clearer rules for implementations.

This helps implementations know how to handle corner cases, and helps
users know what behavior they can rely on.

R=rnystrom@google.com
==========

to

==========
Add clearer rules for implementations.

This helps implementations know how to handle corner cases, and helps
users know what behavior they can rely on.

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/stream_channel/commit/c8515f0d6461faeb5c2e8a9cbd...
==========

[nweiz, 2016-01-21 23:29:19]

Committed patchset #1 (id:1) manually as
c8515f0d6461faeb5c2e8a9cbd58d1924809ae86 (presubmit successful).

[Bob Nystrom, 2016-01-21 23:41:47]

On 2016/01/21 23:28:58, nweiz wrote:
> On 2016/01/21 12:36:55, gzoechi wrote:
> > On 2016/01/21 01:08:11, nweiz wrote:
> > 
> > I had to read the sentence containing `[sink]—canceling` a few times and
> > wondered what this means.
> > Maybe this some bias of my German native tongue, but I think `-` should be
> > change dot ` - ` (added spaces) or `, `.
> 
> I've considered changing it, but I think I'm going to keep it as-is. This is a
> pretty standard use of the em dash (although apparently in the UK it's more
> usual to add space around it), and it's the most appropriate punctuation to
> indicate that the two sentences are separate but closely related.

For what it's worth, I found the em dash hard to read there too. I would have
considered just using a period or rewording the sentence.