Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 16043007: Create a new scope when analyzing then and else of an if. (Closed)

Created:
7 years, 7 months ago by ngeoffray
Modified:
7 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Create a new scope when analyzing then and else of an if. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=23215

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 7 months ago (2013-05-27 10:44:59 UTC) #1
karlklose
LGTM.
7 years, 7 months ago (2013-05-27 10:50:19 UTC) #2
ngeoffray
7 years, 7 months ago (2013-05-27 12:16:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r23215 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698