Implement operator== and hashCode for bound closures.

Implement operator== and hashCode for bound closures.

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23380

[kasperl, 2013-05-29 13:24:08]

https://codereview.chromium.org/16042014/diff/2002/tests/language/bound_closu...
File tests/language/bound_closure_equality_test.dart (right):

https://codereview.chromium.org/16042014/diff/2002/tests/language/bound_closu...
tests/language/bound_closure_equality_test.dart:16: main() {
We probably also need a test that shows the two non-bound closures aren't equal
(even though they may have the same hash code).

https://codereview.chromium.org/16042014/diff/2002/tests/language/bound_closu...
tests/language/bound_closure_equality_test.dart:17: // Use an array to defeat
type inferencing.
Throw them in a map (or set) too and make sure you can look them up again!

[kasperl, 2013-05-29 13:30:14]

LGTM!

https://codereview.chromium.org/16042014/diff/2002/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (right):

https://codereview.chromium.org/16042014/diff/2002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:958: this.self,
other.self,
Get rid of the this. prefixes.

https://codereview.chromium.org/16042014/diff/2002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:965: self.hashCode,
More indentation.

https://codereview.chromium.org/16042014/diff/2002/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/16042014/diff/2002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:70: // TODO(10938):
the types are stored in the wrong order.
TODO -> BUG

[ngeoffray, 2013-05-29 15:33:19]

Thanks Kasper, PTAL, I added tests, and had to fix the enqueuer to always track
instance functions, until there is a getter that will make sure the BoundClosure
class will be emitted.

https://codereview.chromium.org/16042014/diff/2002/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/lib/js_helper.dart (right):

https://codereview.chromium.org/16042014/diff/2002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:958: this.self,
other.self,
On 2013/05/29 13:30:14, kasperl wrote:
> Get rid of the this. prefixes.

Done.

https://codereview.chromium.org/16042014/diff/2002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/lib/js_helper.dart:965: self.hashCode,
On 2013/05/29 13:30:14, kasperl wrote:
> More indentation.

Done.

https://codereview.chromium.org/16042014/diff/2002/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/16042014/diff/2002/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:70: // TODO(10938):
the types are stored in the wrong order.
On 2013/05/29 13:30:14, kasperl wrote:
> TODO -> BUG

Done.

https://codereview.chromium.org/16042014/diff/2002/tests/language/bound_closu...
File tests/language/bound_closure_equality_test.dart (right):

https://codereview.chromium.org/16042014/diff/2002/tests/language/bound_closu...
tests/language/bound_closure_equality_test.dart:16: main() {
On 2013/05/29 13:24:08, kasperl wrote:
> We probably also need a test that shows the two non-bound closures aren't
equal
> (even though they may have the same hash code).

Done.

https://codereview.chromium.org/16042014/diff/2002/tests/language/bound_closu...
tests/language/bound_closure_equality_test.dart:17: // Use an array to defeat
type inferencing.
On 2013/05/29 13:24:08, kasperl wrote:
> Throw them in a map (or set) too and make sure you can look them up again!

Done.

[kasperl, 2013-05-29 19:08:56]

LGTM.

https://codereview.chromium.org/16042014/diff/7001/tests/language/bound_closu...
File tests/language/bound_closure_equality_test.dart (right):

https://codereview.chromium.org/16042014/diff/7001/tests/language/bound_closu...
tests/language/bound_closure_equality_test.dart:19: var set = new
Set.from(array.map((a) => a.foo));
Check the length of the set. Should be 4, right? Then maybe do:

   set.addAll(array.map((a) => a.foo));
  
and re-check the length.

[ngeoffray, 2013-05-30 06:45:46]

Thanks Kasper.

https://codereview.chromium.org/16042014/diff/7001/tests/language/bound_closu...
File tests/language/bound_closure_equality_test.dart (right):

https://codereview.chromium.org/16042014/diff/7001/tests/language/bound_closu...
tests/language/bound_closure_equality_test.dart:19: var set = new
Set.from(array.map((a) => a.foo));
On 2013/05/29 19:08:56, kasperl wrote:
> Check the length of the set. Should be 4, right? Then maybe do:
> 
>    set.addAll(array.map((a) => a.foo));
>   
> and re-check the length.

Done.

[ngeoffray, 2013-05-30 06:48:49]

Committed patchset #3 manually as r23380 (presubmit successful).