Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 16039002: Handle empty maps when converting YAML to a string. (Closed)

Created:
7 years, 7 months ago by Bob Nystrom
Modified:
7 years, 7 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle empty maps when converting YAML to a string. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=23184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M sdk/lib/_internal/pub/lib/src/utils.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/test/utils_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
Before this patch, it would just output nothing for the map. That breaks lockfiles that, ...
7 years, 7 months ago (2013-05-24 18:20:57 UTC) #1
nweiz
lgtm
7 years, 7 months ago (2013-05-24 20:29:22 UTC) #2
Bob Nystrom
7 years, 7 months ago (2013-05-24 21:31:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23184 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698