Fix 2 host-checked error with the enqueuer:

Fix 2 host-checked error with the enqueuer:
- Register an exact selector when the target of a call is known at codegen
- Set the tree elements of a codegen item when actually needed: annotations are currently being processed during resolution, and enqueue in the codegen queue. So it might happen that when a helper is needed, it has not  been resolved yet.

R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23841

[ahe, 2013-06-11 08:56:20]

LGTM!

https://codereview.chromium.org/16035026/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/enqueue.dart (right):

https://codereview.chromium.org/16035026/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/enqueue.dart:129: void
addElementToWorkList(Element element);
I think it would be a great time to rename either addToWorkList or
addElementToWorkList.  They basically have the same name.

https://codereview.chromium.org/16035026/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/enqueue.dart:590: TreeElements
getCachedElements(element) {
Why remove the type annotation here?

https://codereview.chromium.org/16035026/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/enqueue.dart:632: // Enable runtime
type support if we discover a getter called runtimeType.
This comment is out of date, more cases have been added here.

https://codereview.chromium.org/16035026/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/enqueue.dart:647: return;
Remove return.

[ngeoffray, 2013-06-11 09:05:14]

Thanks Peter.

https://codereview.chromium.org/16035026/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/enqueue.dart (right):

https://codereview.chromium.org/16035026/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/enqueue.dart:129: void
addElementToWorkList(Element element);
On 2013/06/11 08:56:20, ahe wrote:
> I think it would be a great time to rename either addToWorkList or
> addElementToWorkList.  They basically have the same name.

Done.

https://codereview.chromium.org/16035026/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/enqueue.dart:590: TreeElements
getCachedElements(element) {
On 2013/06/11 08:56:20, ahe wrote:
> Why remove the type annotation here?

Because I'm using the 'constructor' field and that's not on the Element class.

https://codereview.chromium.org/16035026/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/enqueue.dart:632: // Enable runtime
type support if we discover a getter called runtimeType.
On 2013/06/11 08:56:20, ahe wrote:
> This comment is out of date, more cases have been added here.

Done.

https://codereview.chromium.org/16035026/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/enqueue.dart:647: return;
On 2013/06/11 08:56:20, ahe wrote:
> Remove return.

Done.

[ngeoffray, 2013-06-11 09:10:10]

Committed patchset #3 manually as r23841 (presubmit successful).