Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 16021016: dart:io | Fix issue involving SecureServerSocket error handling and HttpServer stream cancellation. (Closed)

Created:
7 years, 6 months ago by Bill Hesse
Modified:
7 years, 6 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Fix issue involving SecureServerSocket error handling and HttpServer stream cancellation. BUG=dartbug.com/11074 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=23801

Patch Set 1 #

Patch Set 2 : Fix errors #

Patch Set 3 : Add tests for cancelOnError on SecureServerSocket. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -19 lines) Patch
M sdk/lib/io/http_impl.dart View 1 2 chunks +9 lines, -4 lines 0 comments Download
M sdk/lib/io/secure_server_socket.dart View 1 chunk +1 line, -5 lines 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 1 2 3 chunks +11 lines, -5 lines 0 comments Download
M tests/standalone/io/secure_server_socket_test.dart View 1 2 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
Make HttpServer close on cancellation of its stream. Make SecureServerSocket not close on a connection ...
7 years, 6 months ago (2013-06-07 08:57:26 UTC) #1
Søren Gjesse
lgtm
7 years, 6 months ago (2013-06-10 08:05:21 UTC) #2
Bill Hesse
7 years, 6 months ago (2013-06-10 09:29:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r23801 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698