Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 16008003: Reapply "Make int a double in argument type checks." (Closed)

Created:
7 years, 7 months ago by karlklose
Modified:
7 years, 6 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Get the interceptor before calling constructorNameFallback. #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : Make getInterceptor recursive. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/interceptors.dart View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_helper.dart View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_number.dart View 1 chunk +8 lines, -1 line 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
karlklose
7 years, 7 months ago (2013-05-24 13:15:14 UTC) #1
ngeoffray
LGTM!
7 years, 7 months ago (2013-05-24 13:18:14 UTC) #2
karlklose
Committed patchset #2 manually as r23229 (presubmit successful).
7 years, 7 months ago (2013-05-27 16:47:55 UTC) #3
karlklose
PTAL.
7 years, 6 months ago (2013-05-28 09:04:29 UTC) #4
karlklose
PTAL.
7 years, 6 months ago (2013-05-28 11:52:42 UTC) #5
ngeoffray
LGTM!
7 years, 6 months ago (2013-05-28 11:57:37 UTC) #6
karlklose
7 years, 6 months ago (2013-05-28 13:41:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 manually as r23267 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698