Issue 16007003: Optimize internals of multiplex-streams.

Issue 16007003: Optimize internals of multiplex-streams. (Closed)

Created:
7 years, 6 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 6 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Optimize internals of multiplex-streams. Make the multiplex streams broadcast streams. This allows you to listen twice on the same stream, instead of having to get a new stream each time. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=23256

Patch Set 1 #

Patch Set 2 : Moved _onCancel out of firing loop. More documentation. #

Patch Set 3 : Renamed multiplex to broadcast. #

Patch Set 4 : Now relative to correct base #

Total comments: 4

Patch Set 5 : Address comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -49 lines)			Patch
M	pkg/scheduled_test/lib/src/mock_clock.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/async/stream_controller.dart	View	1 2 3 4	4 chunks	+179 lines, -34 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/mdv_observe_impl/mdv_observe_impl.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/async/stream_controller_async_test.dart	View	1 2 3	5 chunks	+10 lines, -10 lines	0 comments	Download
M	tools/dom/src/PathObserver.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

To be applied on top of reapply of active subscription CL (or merged with it).

7 years, 6 months ago (2013-05-28 06:09:21 UTC) #1

floitsch

LGTM. https://codereview.chromium.org/16007003/diff/8001/sdk/lib/async/stream_controller.dart File sdk/lib/async/stream_controller.dart (right): https://codereview.chromium.org/16007003/diff/8001/sdk/lib/async/stream_controller.dart#newcode86 sdk/lib/async/stream_controller.dart:86: * Each listener is handled independently, merge lines. ...

7 years, 6 months ago (2013-05-28 11:47:36 UTC) #3

Lasse Reichstein Nielsen

https://codereview.chromium.org/16007003/diff/8001/sdk/lib/async/stream_controller.dart File sdk/lib/async/stream_controller.dart (right): https://codereview.chromium.org/16007003/diff/8001/sdk/lib/async/stream_controller.dart#newcode86 sdk/lib/async/stream_controller.dart:86: * Each listener is handled independently, It was actually ...

7 years, 6 months ago (2013-05-28 12:06:04 UTC) #4

Lasse Reichstein Nielsen

7 years, 6 months ago (2013-05-28 12:06:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r23256 (presubmit successful).

Expand Messages | Collapse Messages