Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 16001005: Changed buildbot annotated steps to run tests on ARM device (Closed)

Created:
7 years, 6 months ago by kustermann
Modified:
7 years, 6 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Changed buildbot annotated steps to run tests on ARM device R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=23269

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -43 lines) Patch
M tools/bots/cross-vm.py View 1 2 2 chunks +112 lines, -42 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
Request for initial comments.
7 years, 6 months ago (2013-05-28 13:14:44 UTC) #1
ricow1
LGTM https://codereview.chromium.org/16001005/diff/1/tools/bots/cross-vm.py File tools/bots/cross-vm.py (right): https://codereview.chromium.org/16001005/diff/1/tools/bots/cross-vm.py#newcode34 tools/bots/cross-vm.py:34: 'record_output_%s_%s_%s.json' % (name, arch, mode)) add blank line ...
7 years, 6 months ago (2013-05-28 13:25:52 UTC) #2
kustermann
https://codereview.chromium.org/16001005/diff/1/tools/bots/cross-vm.py File tools/bots/cross-vm.py (right): https://codereview.chromium.org/16001005/diff/1/tools/bots/cross-vm.py#newcode34 tools/bots/cross-vm.py:34: 'record_output_%s_%s_%s.json' % (name, arch, mode)) On 2013/05/28 13:25:52, ricow1 ...
7 years, 6 months ago (2013-05-28 13:39:09 UTC) #3
kustermann
7 years, 6 months ago (2013-05-28 13:46:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r23269 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698