Issue 15999002: Add Stream.drain() method.

Issue 15999002: Add Stream.drain() method. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen

Modified:
7 years, 7 months ago

Reviewers:
Søren Gjesse, floitsch, Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add Stream.drain() method. This method will discard all data on the stream and return a Future to mark the end of the stream. BUG= R=floitsch@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=23140

Patch Set 2 : Clean up impl and comments. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -0 lines)			Patch
	M	sdk/lib/async/stream.dart	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
	M	tests/lib/async/stream_controller_async_test.dart	View		2 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/15999002/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/15999002/diff/1/sdk/lib/async/stream.dart#newcode503 sdk/lib/async/stream.dart:503: * occoured. Discards ... signals ... occured Add ...

7 years, 7 months ago (2013-05-24 11:50:42 UTC) #3

Anders Johnsen

https://codereview.chromium.org/15999002/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/15999002/diff/1/sdk/lib/async/stream.dart#newcode503 sdk/lib/async/stream.dart:503: * occoured. On 2013/05/24 11:50:42, floitsch wrote: > Discards ...

7 years, 7 months ago (2013-05-24 12:45:03 UTC) #4

Anders Johnsen

Committed patchset #2 manually as r23140 (presubmit successful).

7 years, 7 months ago (2013-05-24 12:45:52 UTC) #5

Søren Gjesse

https://codereview.chromium.org/15999002/diff/1/sdk/lib/async/stream.dart File sdk/lib/async/stream.dart (right): https://codereview.chromium.org/15999002/diff/1/sdk/lib/async/stream.dart#newcode505 sdk/lib/async/stream.dart:505: Future drain() => listen(null).asFuture(); Should it maybe have a ...

7 years, 7 months ago (2013-05-24 14:02:04 UTC) #6

floitsch

7 years, 7 months ago (2013-05-24 16:21:33 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/15999002/diff/1/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/15999002/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:505: Future drain() => listen(null).asFuture();
On 2013/05/24 14:02:04, Søren Gjesse wrote:
> Should it maybe have a named optional argument "ignoreError"?

I think that this should be kept as simple as possible.
If you want more fancy behavior just write the 15 characters.

Expand Messages | Collapse Messages