Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 159933008: Make File, Link and Directory extend, not implement, FileSystemEntity. (Closed)

Created:
6 years, 10 months ago by Anders Johnsen
Modified:
6 years, 10 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, Søren Gjesse, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Make File, Link and Directory extend, not implement, FileSystemEntity. BUG= R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=32594

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M sdk/lib/io/directory.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/file.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/link.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 10 months ago (2014-02-12 07:32:49 UTC) #1
kasperl
LGTM.
6 years, 10 months ago (2014-02-12 07:34:09 UTC) #2
Anders Johnsen
6 years, 10 months ago (2014-02-12 07:34:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32594 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698