Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 15989006: Revert until Windows crash is debugged. (Closed)

Created:
7 years, 7 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, Søren Gjesse
Visibility:
Public.

Description

Revert until Windows crash is debugged. Reverts r23218, r23217, r23208, r23207, r23206, r23205, r23204. r23218 | Path observer is listened more than once, so make it multiplex. r23217 | Add StreamController.multiplex constructor. r23208 | Fix bug in streamimpl r23207 | Fix bug in stream iterator. r23206 | Change expectations for http_parser_test. r23205 | Fix bug in stream-impl. r23204 | Make StreamSubscription be the active part of a string. Committed: https://code.google.com/p/dart/source/detail?r=23221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1556 lines, -1621 lines) Patch
M pkg/mdv_observe/lib/src/observable_list.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/scheduled_test/lib/scheduled_process.dart View 6 chunks +9 lines, -8 lines 0 comments Download
M pkg/scheduled_test/lib/src/mock_clock.dart View 2 chunks +13 lines, -11 lines 0 comments Download
M pkg/scheduled_test/lib/src/utils.dart View 1 chunk +20 lines, -31 lines 0 comments Download
M runtime/bin/socket_patch.dart View 2 chunks +5 lines, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/error_group.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/test/error_group_test.dart View 5 chunks +13 lines, -26 lines 0 comments Download
M sdk/lib/async/stream.dart View 10 chunks +69 lines, -84 lines 0 comments Download
M sdk/lib/async/stream_controller.dart View 3 chunks +45 lines, -302 lines 0 comments Download
M sdk/lib/async/stream_impl.dart View 7 chunks +1013 lines, -862 lines 0 comments Download
M sdk/lib/async/stream_pipe.dart View 13 chunks +131 lines, -59 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 chunk +1 line, -3 lines 0 comments Download
M sdk/lib/io/http_parser.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M sdk/lib/io/mime_multipart_parser.dart View 2 chunks +8 lines, -4 lines 0 comments Download
M sdk/lib/mdv_observe_impl/mdv_observe_impl.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/utf/utf_stream.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M tests/lib/async/stream_controller_async_test.dart View 3 chunks +49 lines, -56 lines 0 comments Download
M tests/lib/async/stream_state_helper.dart View 13 chunks +43 lines, -101 lines 0 comments Download
M tests/lib/async/stream_state_nonzero_timer_test.dart View 3 chunks +22 lines, -22 lines 0 comments Download
M tests/lib/async/stream_state_test.dart View 4 chunks +59 lines, -12 lines 0 comments Download
M tests/standalone/io/http_multipart_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/http_parser_test.dart View 2 chunks +14 lines, -20 lines 0 comments Download
M tests/standalone/io/http_redirect_test.dart View 1 chunk +9 lines, -5 lines 0 comments Download
M tests/standalone/io/pipe_server_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/regress_8828_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/src/PathObserver.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
TBR
7 years, 7 months ago (2013-05-27 13:02:32 UTC) #1
Lasse Reichstein Nielsen
Committed patchset #1 manually as r23221 (presubmit successful).
7 years, 7 months ago (2013-05-27 13:03:24 UTC) #2
floitsch
7 years, 7 months ago (2013-05-27 14:53:15 UTC) #3
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698