Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 15987007: Revert r23380, some browser tests fail. (Closed)

Created:
7 years, 6 months ago by ngeoffray
Modified:
7 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert r23380, some browser tests fail. Committed: https://code.google.com/p/dart/source/detail?r=23383

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -217 lines) Patch
M sdk/lib/_internal/compiler/implementation/closure.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/compiler.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/enqueue.dart View 5 chunks +9 lines, -40 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 12 chunks +49 lines, -13 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_helper.dart View 2 chunks +2 lines, -24 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
D tests/language/bound_closure_equality_test.dart View 1 chunk +0 lines, -76 lines 0 comments Download
M tests/language/language.status View 2 chunks +0 lines, -3 lines 0 comments Download
D tests/language/local_function_non_equal_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/language/static_closure_identical_test.dart View 1 chunk +0 lines, -17 lines 0 comments Download
M tests/utils/dummy_compiler_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/utils/recursive_import_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
Committed patchset #2 manually as r23383 (presubmit successful).
7 years, 6 months ago (2013-05-30 07:05:48 UTC) #1
ngeoffray
TBR
7 years, 6 months ago (2013-05-30 07:05:51 UTC) #2
kasperl
7 years, 6 months ago (2013-05-30 07:17:28 UTC) #3
Message was sent while issue was closed.
LGTM :-(

Powered by Google App Engine
This is Rietveld 408576698