Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 15981003: Make new StreamController().isPaused be true until the first listener arrives. (Closed)

Created:
7 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make new StreamController().isPaused be true until the first listener arrives. This is compatible with what we had before, and makes good sense if you read "isPaused" as "must buffer incoming events". R=floitsch@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=23318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M runtime/bin/socket_patch.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/async/stream_controller.dart View 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
7 years, 6 months ago (2013-05-28 13:55:22 UTC) #1
floitsch
LGTM.
7 years, 6 months ago (2013-05-28 14:48:35 UTC) #2
Søren Gjesse
lgtm
7 years, 6 months ago (2013-05-28 14:52:00 UTC) #3
Lasse Reichstein Nielsen
7 years, 6 months ago (2013-05-29 05:40:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r23318 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698