Issue 15974005: Fix use of HashException in dart:io

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15974005: Fix use of HashException in dart:io (Closed)

Created:
7 years, 6 months ago by Søren Gjesse

Modified:
7 years, 6 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix use of HashException in dart:io TBR=floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=23255 Committed: https://code.google.com/p/dart/source/detail?r=23264

Patch Set 2 : Addressed review comments #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	sdk/lib/io/crypto.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Committed patchset #1 manually as r23255 (presubmit successful).

7 years, 6 months ago (2013-05-28 12:03:59 UTC) #2

floitsch

LGTM with comment. https://codereview.chromium.org/15974005/diff/1/sdk/lib/io/crypto.dart File sdk/lib/io/crypto.dart (right): https://codereview.chromium.org/15974005/diff/1/sdk/lib/io/crypto.dart#newcode183 sdk/lib/io/crypto.dart:183: throw new ArgumentError( Make it a ...

7 years, 6 months ago (2013-05-28 12:28:11 UTC) #3

Søren Gjesse

Committed patchset #2 manually as r23264 (presubmit successful).

7 years, 6 months ago (2013-05-28 13:06:02 UTC) #4

Søren Gjesse

7 years, 6 months ago (2013-05-28 13:06:10 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/15974005/diff/1/sdk/lib/io/crypto.dart
File sdk/lib/io/crypto.dart (right):

https://codereview.chromium.org/15974005/diff/1/sdk/lib/io/crypto.dart#newcod...
sdk/lib/io/crypto.dart:183: throw new ArgumentError(
On 2013/05/28 12:28:11, floitsch wrote:
> Make it a StateError.

Done.

Expand Messages | Collapse Messages

Issue 15974005: Fix use of HashException in dart:io (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Messages