Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 159663004: Avoid over-use of futures in socket. (Closed)

Created:
6 years, 10 months ago by Anders Johnsen
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Avoid over-use of futures in socket. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=32571

Patch Set 1 #

Patch Set 2 : Make socket-completer sync. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -16 lines) Patch
M runtime/bin/socket_patch.dart View 1 13 chunks +19 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 10 months ago (2014-02-11 14:19:39 UTC) #1
Søren Gjesse
lgtm
6 years, 10 months ago (2014-02-11 16:03:15 UTC) #2
Anders Johnsen
6 years, 10 months ago (2014-02-11 19:14:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r32571 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698