Add browser launching functionality.

Add browser launching functionality.

This is to be used for providing easy reproduction steps (i.e. the steps we print out when tests fail)

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23343

[kustermann, 2013-05-29 11:02:34]

https://codereview.chromium.org/15963007/diff/1/tools/testing/dart/launch_bro...
File tools/testing/dart/launch_browser.dart (right):

https://codereview.chromium.org/15963007/diff/1/tools/testing/dart/launch_bro...
tools/testing/dart/launch_browser.dart:9: *   DARTBIN launch_browser.dart
BROWSER_NAME URL
You could add a comment that DARTBIN should be the checked-in one.

https://codereview.chromium.org/15963007/diff/1/tools/testing/dart/launch_bro...
tools/testing/dart/launch_browser.dart:16: const ['safari', 'ff', 'chrome'];
Please add a TODO for me to make this work with android/iOS as well.
In addition to that: Since you already have created a 'Browser.byName'
constructor, you could also move the 'supportedBrowser()' function to a static
'Browser.isSupported()'.

https://codereview.chromium.org/15963007/diff/1/tools/testing/dart/launch_bro...
tools/testing/dart/launch_browser.dart:27: """);
If you use three strings, you can indent then correct.

[ricow1, 2013-05-29 11:46:31]

PTAL

https://codereview.chromium.org/15963007/diff/1/tools/testing/dart/launch_bro...
File tools/testing/dart/launch_browser.dart (right):

https://codereview.chromium.org/15963007/diff/1/tools/testing/dart/launch_bro...
tools/testing/dart/launch_browser.dart:9: *   DARTBIN launch_browser.dart
BROWSER_NAME URL
On 2013/05/29 11:02:34, kustermann wrote:
> You could add a comment that DARTBIN should be the checked-in one.

Done.

https://codereview.chromium.org/15963007/diff/1/tools/testing/dart/launch_bro...
tools/testing/dart/launch_browser.dart:16: const ['safari', 'ff', 'chrome'];
On 2013/05/29 11:02:34, kustermann wrote:
> Please add a TODO for me to make this work with android/iOS as well.
> In addition to that: Since you already have created a 'Browser.byName'
> constructor, you could also move the 'supportedBrowser()' function to a static
> 'Browser.isSupported()'.

Done.

https://codereview.chromium.org/15963007/diff/1/tools/testing/dart/launch_bro...
tools/testing/dart/launch_browser.dart:27: """);
On 2013/05/29 11:02:34, kustermann wrote:
> If you use three strings, you can indent then correct.

Done.

[kustermann, 2013-05-29 11:58:00]

lgtm

https://codereview.chromium.org/15963007/diff/2002/tools/testing/dart/launch_...
File tools/testing/dart/launch_browser.dart (right):

https://codereview.chromium.org/15963007/diff/2002/tools/testing/dart/launch_...
tools/testing/dart/launch_browser.dart:6: * Simple command line interface to
launcing browsers.
launcing -> launching

https://codereview.chromium.org/15963007/diff/2002/tools/testing/dart/launch_...
tools/testing/dart/launch_browser.dart:19: }
This function can be removed now.

[ricow1, 2013-05-29 12:07:38]

Committed patchset #3 manually as r23343 (presubmit successful).

[ricow1, 2013-05-29 12:08:23]

https://codereview.chromium.org/15963007/diff/2002/tools/testing/dart/launch_...
File tools/testing/dart/launch_browser.dart (right):

https://codereview.chromium.org/15963007/diff/2002/tools/testing/dart/launch_...
tools/testing/dart/launch_browser.dart:6: * Simple command line interface to
launcing browsers.
On 2013/05/29 11:58:00, kustermann wrote:
> launcing -> launching

Done.

https://codereview.chromium.org/15963007/diff/2002/tools/testing/dart/launch_...
tools/testing/dart/launch_browser.dart:19: }
On 2013/05/29 11:58:00, kustermann wrote:
> This function can be removed now.

Done.