Issue 15960009: Streamline IL for instantiating type arguments.

Issue 15960009: Streamline IL for instantiating type arguments. (Closed)

Created:
7 years, 7 months ago by Florian Schneider

Modified:
7 years, 7 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Streamline IL for instantiating type arguments. In some cases we would emit a InstantiateTypeArguments IL instruction that was a no-op. This CL avoids this instruction when building the graph, instead of emitting an empty instruction in the back-end. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=23209

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -115 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View		1 chunk	+10 lines, -4 lines	2 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	1 chunk	+24 lines, -26 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	1 chunk	+25 lines, -27 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1	1 chunk	+29 lines, -31 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	1 chunk	+25 lines, -27 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

LGTM. https://codereview.chromium.org/15960009/diff/5001/runtime/vm/flow_graph_builder.cc File runtime/vm/flow_graph_builder.cc (right): https://codereview.chromium.org/15960009/diff/5001/runtime/vm/flow_graph_builder.cc#newcode2303 runtime/vm/flow_graph_builder.cc:2303: type_arguments.IsUninstantiatedIdentity() || This predicate or its negation appears ...

7 years, 7 months ago (2013-05-27 09:22:03 UTC) #2

Florian Schneider

Committed patchset #2 manually as r23209 (presubmit successful).

7 years, 7 months ago (2013-05-27 10:19:55 UTC) #3

Florian Schneider

7 years, 7 months ago (2013-05-27 10:20:11 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/15960009/diff/5001/runtime/vm/flow_graph_buil...
File runtime/vm/flow_graph_builder.cc (right):

https://codereview.chromium.org/15960009/diff/5001/runtime/vm/flow_graph_buil...
runtime/vm/flow_graph_builder.cc:2303: type_arguments.IsUninstantiatedIdentity()
||
On 2013/05/27 09:22:03, kmillikin wrote:
> This predicate or its negation appears over and over.  Do you think it
deserves
> to be a named predicate on the AbstractTypeArguments?

Possibly. I don't have a really good name for such a predicate though.

Expand Messages | Collapse Messages