Issue 15959017: Fix issue with dart2dart translation of parameters (collision risk).

Issue 15959017: Fix issue with dart2dart translation of parameters (collision risk). (Closed)

Created:
7 years, 6 months ago by kasperl

Modified:
7 years, 6 months ago

Reviewers:
Anton Muhin, Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix issue with dart2dart translation of parameters (collision risk). R=antonm@google.com BUG=http://dartbug.com/10996 Committed: https://code.google.com/p/dart/source/detail?r=23458

Patch Set 1 #

Total comments: 4

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -22 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart	View	3 chunks	+14 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart	View	3 chunks	+13 lines, -10 lines	4 comments	Download
M	tests/co19/co19-dart2dart.status	View	2 chunks	+0 lines, -4 lines	0 comments	Download
A +	tests/language/regress_10996_lib.dart	View	1 chunk	+5 lines, -4 lines	0 comments	Download
A	tests/language/regress_10996_test.dart	View	1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm https://codereview.chromium.org/15959017/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart File sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart (right): https://codereview.chromium.org/15959017/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart#newcode216 sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart:216: Function localRenamer = generateUniqueName; maybe drop this local ...

7 years, 6 months ago (2013-05-31 08:50:23 UTC) #2

kasperl

Thanks for the review, Anton! https://codereview.chromium.org/15959017/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart File sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart (right): https://codereview.chromium.org/15959017/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart#newcode216 sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart:216: Function localRenamer = generateUniqueName; ...

7 years, 6 months ago (2013-05-31 08:51:57 UTC) #3

kasperl

7 years, 6 months ago (2013-05-31 08:54:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r23458 (presubmit successful).

Expand Messages | Collapse Messages