Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 15952006: Fix bug in list test. (Closed)

Created:
7 years, 6 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 6 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug in list test. The test assumed that the return of a typeddata-list's toList method did not have a generic type parameter, as it should have. BUG=http://dartbug.com/10708 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=23382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -16 lines) Patch
M tests/corelib/corelib.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/corelib/list_test.dart View 5 chunks +28 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 6 months ago (2013-05-29 12:52:31 UTC) #1
floitsch
LGTM.
7 years, 6 months ago (2013-05-29 13:06:58 UTC) #2
Lasse Reichstein Nielsen
7 years, 6 months ago (2013-05-30 07:04:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r23382 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698