Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 15949008: Use backend's types for native types. Handle "other dependencies". Gets rid of (Closed)

Created:
7 years, 6 months ago by polux
Modified:
7 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use backend's types for native types. Handle "other dependencies". Gets rid of "trusted classes" and pre-populated cache. Fixes a lot of small bugs discovered along the way, in particular in augmentInferredSelectorType where the absence of a key in some map and dynamic where wrongly conflated. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=23668

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address Karl's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -159 lines) Patch
M sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart View 1 30 chunks +165 lines, -138 lines 0 comments Download
M tests/compiler/dart2js/cpa_inference_test.dart View 3 chunks +1 line, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
polux
7 years, 6 months ago (2013-05-30 10:22:13 UTC) #1
karlklose
LGTM. https://codereview.chromium.org/15949008/diff/1/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (right): https://codereview.chromium.org/15949008/diff/1/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart#newcode441 sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:441: static final DynamicTypeMask instance = new DynamicTypeMask(); You ...
7 years, 6 months ago (2013-06-04 08:43:55 UTC) #2
polux
https://codereview.chromium.org/15949008/diff/1/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (right): https://codereview.chromium.org/15949008/diff/1/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart#newcode441 sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:441: static final DynamicTypeMask instance = new DynamicTypeMask(); On 2013/06/04 ...
7 years, 6 months ago (2013-06-06 09:08:44 UTC) #3
polux
7 years, 6 months ago (2013-06-06 09:24:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r23668 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698