Issue 15946002: Allow breakpoints on strict equal

Issue 15946002: Allow breakpoints on strict equal (Closed)

Created:
7 years, 7 months ago by hausner

Modified:
7 years, 7 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Allow breakpoints on strict equal The compiler turns equality checks with null into strict equal comparisons. Make the compiler backend create a pc descriptor for the runtime call so that the debugger can break on x == null and x != null. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=23153

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -60 lines)			Patch
M	runtime/vm/debugger.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	6 chunks	+19 lines, -7 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View	1	1 chunk	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1	2 chunks	+10 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1	3 chunks	+10 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1	2 chunks	+10 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	3 chunks	+10 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	3 chunks	+8 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	10 chunks	+13 lines, -13 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1	2 chunks	+12 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1	2 chunks	+12 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1	2 chunks	+12 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1	2 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/15946002/diff/1/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/15946002/diff/1/runtime/vm/debugger.cc#newcode1246 runtime/vm/debugger.cc:1246: // Line does not contain any tokens. first_toekn_index ...

7 years, 7 months ago (2013-05-24 16:07:32 UTC) #2

hausner

Thank you. https://codereview.chromium.org/15946002/diff/1/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/15946002/diff/1/runtime/vm/debugger.cc#newcode1246 runtime/vm/debugger.cc:1246: // Line does not contain any tokens. ...

7 years, 7 months ago (2013-05-24 16:23:43 UTC) #3

hausner

7 years, 7 months ago (2013-05-24 16:26:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r23153 (presubmit successful).

Expand Messages | Collapse Messages