Issue 15937019: More expectations fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15937019: More expectations fixes (Closed)

Created:
7 years, 6 months ago by vsm

Modified:
7 years, 6 months ago

Reviewers:
Anton Muhin, antonm, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

More expectations fixes Hopefully, this gets everything green. TBR=blois, antonm Committed: https://code.google.com/p/dart/source/detail?r=23522

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	tests/html/html.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	tests/lib/lib.status	View		2 chunks	+5 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsm

Committed patchset #1 manually as r23522 (presubmit successful).

7 years, 6 months ago (2013-06-03 04:07:24 UTC) #1

Anton Muhin

lgtm https://codereview.chromium.org/15937019/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/15937019/diff/1/tests/lib/lib.status#newcode112 tests/lib/lib.status:112: async/multiple_timer_test: Fail, Pass # See Issue 10982 do ...

7 years, 6 months ago (2013-06-03 07:40:27 UTC) #2

vsm

7 years, 6 months ago (2013-06-03 14:25:13 UTC) #3

Message was sent while issue was closed.

On 2013/06/03 07:40:27, Anton Muhin wrote:
> lgtm
> 
> https://codereview.chromium.org/15937019/diff/1/tests/lib/lib.status
> File tests/lib/lib.status (right):
> 
>
https://codereview.chromium.org/15937019/diff/1/tests/lib/lib.status#newcode112
> tests/lib/lib.status:112: async/multiple_timer_test: Fail, Pass # See Issue
> 10982
> do you have any idea what goes on here?

No, nothing beyond what you speculated in the existing bug.  The test appeared
flaky on the Win bots now, so I marked it Pass, Fail.

Expand Messages | Collapse Messages