Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15935008: Remove hackish way of getting the url for browser testing (Closed)

Created:
7 years, 6 months ago by ricow1
Modified:
7 years, 6 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove hackish way of getting the url for browser testing R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=23341

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M tools/testing/dart/test_runner.dart View 1 5 chunks +10 lines, -8 lines 1 comment Download
M tools/testing/dart/test_suite.dart View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ricow1
7 years, 6 months ago (2013-05-29 08:11:37 UTC) #1
kustermann
https://codereview.chromium.org/15935008/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/15935008/diff/1/tools/testing/dart/test_runner.dart#newcode408 tools/testing/dart/test_runner.dart:408: I'd really prefer if you pass it in via ...
7 years, 6 months ago (2013-05-29 08:16:11 UTC) #2
ricow1
7 years, 6 months ago (2013-05-29 08:24:39 UTC) #3
ricow1
https://codereview.chromium.org/15935008/diff/1/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/15935008/diff/1/tools/testing/dart/test_runner.dart#newcode408 tools/testing/dart/test_runner.dart:408: On 2013/05/29 08:16:11, kustermann wrote: > I'd really prefer ...
7 years, 6 months ago (2013-05-29 08:25:42 UTC) #4
kustermann
lgtm with comment https://codereview.chromium.org/15935008/diff/4001/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/15935008/diff/4001/tools/testing/dart/test_runner.dart#newcode396 tools/testing/dart/test_runner.dart:396: expectedOutcomes, info, isNegative, this.testingUrl, this.testingUrl -> ...
7 years, 6 months ago (2013-05-29 08:46:41 UTC) #5
ricow1
7 years, 6 months ago (2013-05-29 10:38:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 manually as r23341 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698