Implement InstanceMirror.getField/setField (minified).

Implement InstanceMirror.getField/setField (minified).

R=kasperl@google.com

Committed: https://code.google.com/p/dart/source/detail?r=23676

[kasperl, 2013-06-06 08:21:42]

LGTM with one comment:

https://codereview.chromium.org/15934017/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart (right):

https://codereview.chromium.org/15934017/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart:293:
InstanceMirror setField(Symbol fieldName, Object arg) {
How do we know that this returns an InstanceMirror (seeing that it returns the
arg)? What's the intended behavior? Is the type annotation just wrong?

[ahe, 2013-06-06 11:53:00]

https://codereview.chromium.org/15934017/diff/1/dart/sdk/lib/_internal/compil...
File dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart (right):

https://codereview.chromium.org/15934017/diff/1/dart/sdk/lib/_internal/compil...
dart/sdk/lib/_internal/compiler/implementation/lib/js_mirrors.dart:293:
InstanceMirror setField(Symbol fieldName, Object arg) {
On 2013/06/06 08:21:42, kasperl wrote:
> How do we know that this returns an InstanceMirror (seeing that it returns the
> arg)? What's the intended behavior? Is the type annotation just wrong?

The method "reflect" always returns an InstanceMirror, and arg is supposed to be
a non-mirror'ed instance.

[ahe, 2013-06-06 11:56:00]

Committed patchset #1 manually as r23676 (presubmit successful).