Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 15934013: Enable optimization of try-finally in the VM's optimizing compiler. (Closed)

Created:
7 years, 6 months ago by Florian Schneider
Modified:
7 years, 6 months ago
Reviewers:
karlklose, ahe, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Enable optimization of try-finally in the VM's optimizing compiler. I changed the status of two co19 tests that crash with a stack overflow because of recursion in dart2js. Optimized functions may take more stack space, and this CL enables optimizations for more functions in dart2js. I added smaller versions of those two tests to our own test suite. BUG=dart:8857 R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=23597

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -1 line) Patch
M runtime/vm/parser.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/language/smaller_4_Interface_Types_A11_t01_test.dart View 1 1 chunk +144 lines, -0 lines 0 comments Download
A tests/language/smaller_4_Interface_Types_A11_t02_test.dart View 1 1 chunk +144 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Florian Schneider
7 years, 6 months ago (2013-06-04 14:11:58 UTC) #1
ahe
lgtm https://codereview.chromium.org/15934013/diff/1/tests/language/smaller_4_Interface_Types_A11_t01_test.dart File tests/language/smaller_4_Interface_Types_A11_t01_test.dart (right): https://codereview.chromium.org/15934013/diff/1/tests/language/smaller_4_Interface_Types_A11_t01_test.dart#newcode7 tests/language/smaller_4_Interface_Types_A11_t01_test.dart:7: // This is a small version of the ...
7 years, 6 months ago (2013-06-04 14:14:16 UTC) #2
karlklose
https://codereview.chromium.org/15934013/diff/1/tests/language/smaller_4_Interface_Types_A11_t01_test.dart File tests/language/smaller_4_Interface_Types_A11_t01_test.dart (right): https://codereview.chromium.org/15934013/diff/1/tests/language/smaller_4_Interface_Types_A11_t01_test.dart#newcode2 tests/language/smaller_4_Interface_Types_A11_t01_test.dart:2: * Copyright (c) 2011, the Dart project authors. Please ...
7 years, 6 months ago (2013-06-04 14:18:10 UTC) #3
Florian Schneider
Committed patchset #2 manually as r23597 (presubmit successful).
7 years, 6 months ago (2013-06-04 14:35:50 UTC) #4
Florian Schneider
https://codereview.chromium.org/15934013/diff/1/tests/language/smaller_4_Interface_Types_A11_t01_test.dart File tests/language/smaller_4_Interface_Types_A11_t01_test.dart (right): https://codereview.chromium.org/15934013/diff/1/tests/language/smaller_4_Interface_Types_A11_t01_test.dart#newcode2 tests/language/smaller_4_Interface_Types_A11_t01_test.dart:2: * Copyright (c) 2011, the Dart project authors. Please ...
7 years, 6 months ago (2013-06-04 14:38:25 UTC) #5
srdjan
7 years, 6 months ago (2013-06-04 15:32:49 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698