Issue 15930013: Fixing codegen issues from Blink roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15930013: Fixing codegen issues from Blink roll. (Closed)

Created:
7 years, 6 months ago by blois

Modified:
7 years, 6 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing codegen issues from Blink roll. Appears that Blink is in the process of renaming WebKit IDL types, but right now they have duplicated types. BUG= Committed: https://code.google.com/p/dart/source/detail?r=23757

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1195 lines, -1203 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	9 chunks	+561 lines, -569 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	10 chunks	+623 lines, -631 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	3 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

Diff looks a little odd because it's removing duplicated types, dart2js tests look OK at ...

7 years, 6 months ago (2013-06-07 18:25:37 UTC) #1

blois

Committed patchset #1 manually as r23757 (presubmit successful).

7 years, 6 months ago (2013-06-07 18:26:08 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages