Issue 15930003: - Allocate symbols for 'get:' and 'set:'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15930003: - Allocate symbols for 'get:' and 'set:' (Closed)

Created:
7 years, 7 months ago by siva

Modified:
7 years, 7 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Allocate symbols for 'get:' and 'set:' - Remove some redundant handle creation R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=23110

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -26 lines)			Patch
M	runtime/vm/object.cc	View	1	6 chunks	+15 lines, -25 lines	0 comments	Download
M	runtime/vm/parser.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/symbols.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/15930003/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/15930003/diff/1/runtime/vm/object.cc#newcode6322 runtime/vm/object.cc:6322: Namespace& import = Namespace::Handle(); ?

7 years, 7 months ago (2013-05-23 22:30:17 UTC) #3

siva

https://codereview.chromium.org/15930003/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/15930003/diff/1/runtime/vm/object.cc#newcode6322 runtime/vm/object.cc:6322: Namespace& import = Namespace::Handle(); On 2013/05/23 22:30:17, Ivan Posva ...

7 years, 7 months ago (2013-05-23 22:39:31 UTC) #4

siva

7 years, 7 months ago (2013-05-23 22:59:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r23110 (presubmit successful).

Expand Messages | Collapse Messages

Issue 15930003: - Allocate symbols for 'get:' and 'set:' (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages