Issue 15924007: Remove shadow_dom_layout_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15924007: Remove shadow_dom_layout_test. (Closed)

Created:
7 years, 6 months ago by Anton Muhin

Modified:
7 years, 6 months ago

Reviewers:
Siggi Cherem (dart-lang), blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove shadow_dom_layout_test. TBR=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=23340

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -47 lines)			Patch
	D	tests/html/shadow_dom_layout_test.dart	View		1 chunk	+0 lines, -36 lines	0 comments	Download
	D	tests/html/shadow_dom_layout_test.txt	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

Committed patchset #1 manually as r23340 (presubmit successful).

7 years, 6 months ago (2013-05-29 10:24:59 UTC) #2

Siggi Cherem (dart-lang)

7 years, 6 months ago (2013-05-29 16:58:39 UTC) #3

Message was sent while issue was closed.

+blois

LGTM, but let's please add a bug to create an equivalent test again?

The reason we had this as a layout test was that shadow dom was encapsulated and
we didn't have a programatic way to check that it was rendered correctly. I
think shadow DOM change since we wrote this test, so it might be possible to
test this another way. Otherwise we might need to keep layout tests around.

Expand Messages | Collapse Messages