Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1591463002: Indent functions in named argument lists with non-functions. (Closed)

Created:
4 years, 11 months ago by Bob Nystrom
Modified:
4 years, 11 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Indent functions in named argument lists with non-functions. This case doesn't come into play often, but when it does, it looks ugly to have the function bodies break out of the surrounding indentation of the named argument list. Fix #478. R=kevmoo@google.com Committed: https://github.com/dart-lang/dart_style/commit/fd53e2aee6fe574569132fcf7452e5ff7fb2d052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -1 line) Patch
M CHANGELOG.md View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/argument_list_visitor.dart View 1 chunk +25 lines, -0 lines 0 comments Download
A test/regression/0400/0478.stmt View 1 chunk +42 lines, -0 lines 0 comments Download
M test/splitting/function_arguments.stmt View 1 chunk +23 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
4 years, 11 months ago (2016-01-14 22:08:48 UTC) #2
kevmoo
lgtm
4 years, 11 months ago (2016-01-14 22:12:53 UTC) #3
Bob Nystrom
4 years, 11 months ago (2016-01-14 22:48:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fd53e2aee6fe574569132fcf7452e5ff7fb2d052 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698