Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1327)

Issue 1590723005: Fix some tests that were broken in the library tag removal. (Closed)

Created:
4 years, 11 months ago by nweiz
Modified:
4 years, 11 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some tests that were broken in the library tag removal. Closes #1382 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/b6ffde4e075586a0c38bf77b4f9aa297c28b6780

Patch Set 1 #

Patch Set 2 : Missed a test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M test/dart2js/allows_import_in_dart_code_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M test/dart2js/compiles_generated_file_from_dependency_outside_web_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M test/dart2js/compiles_generated_file_from_dependency_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M test/dart2js/compiles_imported_generated_file_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
nweiz
4 years, 11 months ago (2016-01-15 02:42:39 UTC) #1
Bob Nystrom
lgtm
4 years, 11 months ago (2016-01-15 17:05:34 UTC) #2
nweiz
4 years, 11 months ago (2016-01-15 21:41:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b6ffde4e075586a0c38bf77b4f9aa297c28b6780 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698