Issue 15907020: - Define bool on Windows when not compiling C++.

https://codereview.chromium.org/15907020/diff/1/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://codereview.chromium.org/15907020/diff/1/runtime/include/dart_api.h#newcode28 runtime/include/dart_api.h:28: #elif defined(_WIN32) Not part of this chhange, but shouldn't ...

7 years, 6 months ago (2013-06-03 10:57:32 UTC) #3

Cutch

7 years, 6 months ago (2013-06-03 14:52:21 UTC) #4

Ivan Posva

7 years, 6 months ago (2013-06-03 15:42:52 UTC) #5

Message was sent while issue was closed.

-Ivan

https://codereview.chromium.org/15907020/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/15907020/diff/1/runtime/include/dart_api.h#ne...
runtime/include/dart_api.h:28: #elif defined(_WIN32)
On 2013/06/03 14:52:21, Cutch wrote:
> On 2013/06/03 10:57:32, Søren Gjesse wrote:
> > Not part of this chhange, but shouldn't this be _MSC_VER instead of _WIN32?
> 
> I believe you're correct. It's MSVC that lacks support for stdbool not the
WIN32
> platform.

As you can see below with all of the other int types, it is assumed that _WIN32
and !__CYGWIN__ expects a non-C99 based compiler such as MSVC.

__CYGWIN__ is not supported at the moment and is caught a couple of lines
further up.

So I am leaving this as it is for now. If we really get somebody trying to build
on Windows with some other toolchain than MSVC, then we can address it then.

Expand Messages | Collapse Messages